rust/compiler/rustc_resolve/src
Matthias Krüger 69a8c139f1
Rollup merge of #124840 - bvanjoi:fix-124490, r=petrochenkov
resolve: mark it undetermined if single import is not has any bindings

- Fixes #124490
- Fixes #125013

This issue arises from incorrect resolution updates, for example:

```rust
mod a {
    pub mod b {
        pub mod c {}
    }
}

use a::*;

use b::c;
use c as b;

fn main() {}
```

1. In the first loop, binding `(root, b)` is refer to `root:🅰️:b` due to `use a::*`.
    1. However, binding `(root, c)` isn't defined by `use b::c` during this stage because `use c as b` falls under the `single_imports` of `(root, b)`, where the `imported_module` hasn't been computed yet. This results in marking the `path_res` for `b` as `Indeterminate`.
    2. Then, the `imported_module` for `use c as b` will be recorded.
2. In the second loop, `use b::c` will be processed again:
    1. Firstly, it attempts to find the `path_res` for `(root, b)`.
    2. It will iterate through the `single_imports` of `use b::c`, encounter `use c as b`, attempt to resolve `c` in `root`, and ultimately return `Err(Undetermined)`, thus passing the iterator.
    3. Use the binding `(root, b)` -> `root:🅰️:b` introduced by `use a::*` and ultimately return `root:🅰️:b` as the `path_res` of `b`.
    4. Then define the binding `(root, c)` -> `root:🅰️🅱️:c`.
3. Then process `use c as b`, update the resolution for `(root, b)` to refer to `root:🅰️🅱️:c`, ultimately causing inconsistency.

In my view, step `2.2` has an issue where it should exit early, similar to the behavior when there's no `imported_module`. Therefore, I've added an attribute called `indeterminate` to `ImportData`. This will help us handle only those single imports that have at least one determined binding.

r? ``@petrochenkov``
2024-06-05 18:21:11 +02:00
..
late Rename HIR TypeBinding to AssocItemConstraint and related cleanup 2024-05-30 22:52:33 +02:00
build_reduced_graph.rs Auto merge of #125105 - nnethercote:rustc_resolve-cleanups, r=estebank 2024-05-18 06:36:44 +00:00
check_unused.rs Rename buffer_lint_with_diagnostic to buffer_lint 2024-05-21 20:16:39 +00:00
def_collector.rs Create const block DefIds in typeck instead of ast lowering 2024-05-28 13:38:43 +00:00
diagnostics.rs Improve renaming suggestion for names with leading underscores 2024-05-30 21:39:12 -05:00
effective_visibilities.rs Auto merge of #125105 - nnethercote:rustc_resolve-cleanups, r=estebank 2024-05-18 06:36:44 +00:00
errors.rs Move "elided lifetime in path" to subdiagnostic struct 2024-04-21 07:45:03 +00:00
ident.rs resolve: mark it undetermined if single import is not has any bindings 2024-06-04 12:40:41 +08:00
imports.rs resolve: mark it undetermined if single import is not has any bindings 2024-06-04 12:40:41 +08:00
late.rs Rollup merge of #125635 - fmease:mv-type-binding-assoc-item-constraint, r=compiler-errors 2024-05-31 08:50:22 +02:00
lib.rs Rollup merge of #125381 - estebank:issue-96799, r=petrochenkov 2024-05-29 03:25:08 +01:00
macros.rs Auto merge of #125326 - weiznich:move/do_not_recommend_to_diganostic_namespace, r=compiler-errors 2024-05-22 04:14:08 +00:00
rustdoc.rs Remove #[macro_use] extern crate tracing from rustc_resolve. 2024-05-10 15:34:41 +10:00