Matthias Krüger fd4ad33242 Rollup merge of #137465 - Zalathar:visit-primary, r=oli-obk ... mir_build: Avoid some useless work when visiting "primary" bindings While looking over `visit_primary_bindings`, I noticed that it does a bunch of extra work to build up a collection of “user-type projections”, even though 2/3 of its call sites don't even use them. Those callers can get the same result via `thir::Pat::walk_always`. (And it turns out that doing so also avoids creating some redundant user-type entries in MIR for some binding constructs.) I also noticed that even when the user-type projections *are* used, the process of building them ends up eagerly cloning some nested vectors at every recursion step, even in cases where they won't be used because the current subpattern has no bindings. To avoid this, the visit method now assembles a linked list on the stack containing the information that *would* be needed to create projections, and only creates the concrete projections as needed when a primary binding is encountered. Some relevant prior PRs: - #55274 - 0bfe184b1a in #55937 --- There should be no user-visible change in compiler output.		2025-03-17 16:34:48 +01:00
..
rustc	Revert "Use workspace lints for crates in compiler/ #138084"	2025-03-10 18:12:47 +08:00
rustc_abi	Use {Decodable,Encodable}_NoContext in type_ir	2025-03-15 06:34:36 +00:00
rustc_arena	Remove #![warn(unreachable_pub)] from all compiler/ crates.	2025-03-11 13:14:21 +11:00
rustc_ast	Rollup merge of #136355 - GuillaumeGomez:proc-macro_add_value_retrieval_methods, r=Amanieu	2025-03-17 05:47:48 -04:00
rustc_ast_ir	Use {Decodable,Encodable}_NoContext in type_ir	2025-03-15 06:34:36 +00:00
rustc_ast_lowering	Stabilize asm_goto	2025-03-17 11:12:10 +00:00
rustc_ast_passes	Rollup merge of #138331 - nnethercote:use-RUSTC_LINT_FLAGS-more, r=onur-ozkan,jieyouxu	2025-03-12 10:19:30 -07:00
rustc_ast_pretty	Rollup merge of #138331 - nnethercote:use-RUSTC_LINT_FLAGS-more, r=onur-ozkan,jieyouxu	2025-03-12 10:19:30 -07:00
rustc_attr_data_structures	Rollup merge of #138331 - nnethercote:use-RUSTC_LINT_FLAGS-more, r=onur-ozkan,jieyouxu	2025-03-12 10:19:30 -07:00
rustc_attr_parsing	Auto merge of #138414 - matthiaskrgr:rollup-9ablqdb, r=matthiaskrgr	2025-03-12 17:27:43 +00:00
rustc_baked_icu_data	Add unreachable_pub to RUSTC_LINT_FLAGS for compiler/ crates.	2025-03-11 13:14:21 +11:00
rustc_borrowck	Auto merge of #138595 - jhpratt:rollup-09pvfzu, r=jhpratt	2025-03-17 10:43:38 +00:00
rustc_builtin_macros	Auto merge of #138414 - matthiaskrgr:rollup-9ablqdb, r=matthiaskrgr	2025-03-12 17:27:43 +00:00
rustc_codegen_cranelift	Rollup merge of #138082 - thaliaarchi:slice-cfg-not-test, r=thomcc	2025-03-16 09:40:05 +08:00
rustc_codegen_gcc	intrinsics: remove unnecessary leading underscore from argument names	2025-03-12 08:04:09 +01:00
rustc_codegen_llvm	Auto merge of #137011 - LuuuXXX:promote-ohos-with-host-tools, r=Amanieu	2025-03-16 18:42:18 +00:00
rustc_codegen_ssa	Rollup merge of #137449 - compiler-errors:control-flow, r=Amanieu,lnicola	2025-03-17 16:34:47 +01:00
rustc_const_eval	Stop relying on rustc_type_ir in non-type-system crates	2025-03-15 06:42:48 +00:00
rustc_data_structures	Auto merge of #137011 - LuuuXXX:promote-ohos-with-host-tools, r=Amanieu	2025-03-16 18:42:18 +00:00
rustc_driver	Revert "Use workspace lints for crates in compiler/ #138084"	2025-03-10 18:12:47 +08:00
rustc_driver_impl	Auto merge of #138566 - yotamofek:pr/strip-prefix, r=nnethercote	2025-03-17 07:34:25 +00:00
rustc_error_codes	Rollup merge of #138331 - nnethercote:use-RUSTC_LINT_FLAGS-more, r=onur-ozkan,jieyouxu	2025-03-12 10:19:30 -07:00
rustc_error_messages	Rollup merge of #138404 - bjorn3:sysroot_handling_cleanup, r=petrochenkov,jieyouxu	2025-03-13 11:28:35 +01:00
rustc_errors	Do not suggest using -Zmacro-backtrace for builtin macros	2025-03-14 19:50:03 +00:00
rustc_expand	Use strip_{prefix|suffix} instead of {starts|ends}_with+indexing	2025-03-17 07:06:10 +00:00
rustc_feature	Stabilize asm_goto	2025-03-17 11:12:10 +00:00
rustc_fluent_macro	Remove #![warn(unreachable_pub)] from all compiler/ crates.	2025-03-11 13:14:21 +11:00
rustc_fs_util	Revert "Use workspace lints for crates in compiler/ #138084"	2025-03-10 18:12:47 +08:00
rustc_graphviz	Remove #![warn(unreachable_pub)] from all compiler/ crates.	2025-03-11 13:14:21 +11:00
rustc_hashes	Revert "Use workspace lints for crates in compiler/ #138084"	2025-03-10 18:12:47 +08:00
rustc_hir	Rollup merge of #138109 - Kohei316:feat/rust-doc-precise-capturing-arg, r=aDotInTheVoid,compiler-errors	2025-03-13 11:28:26 +01:00
rustc_hir_analysis	Auto merge of #138595 - jhpratt:rollup-09pvfzu, r=jhpratt	2025-03-17 10:43:38 +00:00
rustc_hir_pretty	Fix HIR param pretty printing some more.	2025-03-14 09:45:41 +11:00
rustc_hir_typeck	Rollup merge of #137449 - compiler-errors:control-flow, r=Amanieu,lnicola	2025-03-17 16:34:47 +01:00
rustc_incremental	Auto merge of #138416 - Manishearth:rollup-fejor9p, r=Manishearth	2025-03-13 01:37:26 +00:00
rustc_index	Use {Decodable,Encodable}_NoContext in type_ir	2025-03-15 06:34:36 +00:00
rustc_index_macros	Add unreachable_pub to RUSTC_LINT_FLAGS for compiler/ crates.	2025-03-11 13:14:21 +11:00
rustc_infer	Fold visit into ty	2025-03-15 06:34:36 +00:00
rustc_interface	Rollup merge of #138404 - bjorn3:sysroot_handling_cleanup, r=petrochenkov,jieyouxu	2025-03-13 11:28:35 +01:00
rustc_lexer	Rollup merge of #136355 - GuillaumeGomez:proc-macro_add_value_retrieval_methods, r=Amanieu	2025-03-17 05:47:48 -04:00
rustc_lint	Stop relying on rustc_type_ir in non-type-system crates	2025-03-15 06:42:48 +00:00
rustc_lint_defs	Remove #![warn(unreachable_pub)] from all compiler/ crates.	2025-03-11 13:14:21 +11:00
rustc_llvm	Auto merge of #137011 - LuuuXXX:promote-ohos-with-host-tools, r=Amanieu	2025-03-16 18:42:18 +00:00
rustc_log	Revert "Use workspace lints for crates in compiler/ #138084"	2025-03-10 18:12:47 +08:00
rustc_macros	Move codec module back into middle	2025-03-15 06:42:48 +00:00
rustc_metadata	Flatten and simplify some control flow	2025-03-17 09:15:49 +00:00
rustc_middle	Rollup merge of #137465 - Zalathar:visit-primary, r=oli-obk	2025-03-17 16:34:48 +01:00
rustc_mir_build	Build UserTypeProjections lazily when visiting bindings	2025-03-16 12:16:09 +11:00
rustc_mir_dataflow	Auto merge of #138414 - matthiaskrgr:rollup-9ablqdb, r=matthiaskrgr	2025-03-12 17:27:43 +00:00
rustc_mir_transform	Don't drop Rvalue::WrapUnsafeBinder during GVN	2025-03-15 18:10:55 +00:00
rustc_monomorphize	Auto merge of #138414 - matthiaskrgr:rollup-9ablqdb, r=matthiaskrgr	2025-03-12 17:27:43 +00:00
rustc_next_trait_solver	Use {Decodable,Encodable}_NoContext in type_ir	2025-03-15 06:34:36 +00:00
rustc_parse	Rollup merge of #136355 - GuillaumeGomez:proc-macro_add_value_retrieval_methods, r=Amanieu	2025-03-17 05:47:48 -04:00
rustc_parse_format	Rollup merge of #136355 - GuillaumeGomez:proc-macro_add_value_retrieval_methods, r=Amanieu	2025-03-17 05:47:48 -04:00
rustc_passes	Flatten and simplify some control flow	2025-03-17 09:15:49 +00:00
rustc_pattern_analysis	Remove #![warn(unreachable_pub)] from all compiler/ crates.	2025-03-11 13:14:21 +11:00
rustc_privacy	Suppress must_use in compiler and tools	2025-03-16 17:47:57 +00:00
rustc_query_impl	Auto merge of #137011 - LuuuXXX:promote-ohos-with-host-tools, r=Amanieu	2025-03-16 18:42:18 +00:00
rustc_query_system	Rollup merge of #138331 - nnethercote:use-RUSTC_LINT_FLAGS-more, r=onur-ozkan,jieyouxu	2025-03-12 17:59:08 +01:00
rustc_resolve	resolve: Avoid some unstable iteration	2025-03-14 18:34:08 +03:00
rustc_sanitizers	Squash fold into ty	2025-03-15 06:34:36 +00:00
rustc_serialize	Use {Decodable,Encodable}_NoContext in type_ir	2025-03-15 06:34:36 +00:00
rustc_session	Rename PrintKind::{AllTargetSpecs,TargetSpec} to {AllTargetSpecsJson,TargetSpecJson}	2025-03-16 21:56:02 +08:00
rustc_smir	Auto merge of #138416 - Manishearth:rollup-fejor9p, r=Manishearth	2025-03-13 01:37:26 +00:00
rustc_span	Do not suggest using -Zmacro-backtrace for builtin macros	2025-03-14 19:50:03 +00:00
rustc_symbol_mangling	Auto merge of #138414 - matthiaskrgr:rollup-9ablqdb, r=matthiaskrgr	2025-03-12 17:27:43 +00:00
rustc_target	Rollup merge of #137621 - Berrysoft:cygwin-std, r=joboet	2025-03-17 05:47:49 -04:00
rustc_trait_selection	Rollup merge of #137449 - compiler-errors:control-flow, r=Amanieu,lnicola	2025-03-17 16:34:47 +01:00
rustc_traits	Rollup merge of #138394 - lcnr:yeet-variant, r=compiler-errors	2025-03-12 10:19:32 -07:00
rustc_transmute	Auto merge of #138414 - matthiaskrgr:rollup-9ablqdb, r=matthiaskrgr	2025-03-12 17:27:43 +00:00
rustc_ty_utils	Stop relying on rustc_type_ir in non-type-system crates	2025-03-15 06:42:48 +00:00
rustc_type_ir	Suppress must_use in compiler and tools	2025-03-16 17:47:57 +00:00
rustc_type_ir_macros	Fold visit into ty	2025-03-15 06:34:36 +00:00
stable_mir	Revert "Use workspace lints for crates in compiler/ #138084"	2025-03-10 18:12:47 +08:00