user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not error out on missing parent metrics

Browse source
This commit is contained in:
Jakub Beránek 2025-03-15 11:11:56 +01:00
parent b4cccf0158
commit e845318111
1 changed files with 18 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/ci/citool/src/main.rs
View file

@ -150,11 +150,24 @@ fn postprocess_metrics(
return Ok(());
};
let parent_metrics =
download_job_metrics(&job_name, &parent).context("cannot download parent metrics")?;
let job_metrics =
HashMap::from([(job_name, JobMetrics { parent: Some(parent_metrics), current: metrics })]);
output_test_diffs(job_metrics);
// This command is executed also on PR builds, which might not have parent metrics
// available, because some PR jobs don't run on auto builds, and PR jobs do not upload metrics
// due to missing permissions.
// To avoid having to detect if this is a PR job, and to avoid having failed steps in PR jobs,
// we simply print an error if the parent metrics were not found, but otherwise exit
// successfully.
match download_job_metrics(&job_name, &parent).context("cannot download parent metrics") {
Ok(parent_metrics) => {
let job_metrics = HashMap::from([(
job_name,
JobMetrics { parent: Some(parent_metrics), current: metrics },
)]);
output_test_diffs(job_metrics);
}
Err(error) => {
eprintln!("Metrics for job `{job_name}` and commit `{parent}` not found: {error:?}");
}
}
Ok(())
}