Defactored Bytes::read

Removed unneeded refactoring of read_one_byte, which removed the unneeded dynamic dispatch (`dyn Read`) used by that function.
This commit is contained in:
Nathan West 2018-11-29 20:36:32 -05:00 committed by GitHub
parent 3e90a12a8a
commit f59d645a9b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -1936,18 +1936,6 @@ impl<T: BufRead> BufRead for Take<T> {
}
}
fn read_one_byte(reader: &mut dyn Read) -> Option<Result<u8>> {
let mut buf = [0];
loop {
return match reader.read(&mut buf) {
Ok(0) => None,
Ok(..) => Some(Ok(buf[0])),
Err(ref e) if e.kind() == ErrorKind::Interrupted => continue,
Err(e) => Some(Err(e)),
};
}
}
/// An iterator over `u8` values of a reader.
///
/// This struct is generally created by calling [`bytes`] on a reader.
@ -1965,7 +1953,15 @@ impl<R: Read> Iterator for Bytes<R> {
type Item = Result<u8>;
fn next(&mut self) -> Option<Result<u8>> {
read_one_byte(&mut self.inner)
let mut buf = [0];
loop {
return match self.inner.read(&mut buf) {
Err(ref e) if e.kind() == ErrorKind::Interrupted => continue,
Ok(0) => None,
Ok(..) => Some(Ok(buf[0])),
Err(e) => Some(Err(e)),
};
}
}
}