Weihang Lo
1e5dad0bef
Update cargo
...
5 commits in ba607b23db8398723d659249d9abf5536bc322e5..e027c4b5d25af2119b1956fac42863b9b3242744
2022-11-22 20:52:39 +0000 to 2022-11-25 19:44:46 +0000
- fix: Move off atty to resolve soundness issue (rust-lang/cargo#11420 )
- add newline char to `cargo install .` error message for easier reading. (rust-lang/cargo#11401 )
- chore: Upgrade to env_logger (rust-lang/cargo#11417 )
- Change rustdoc-scrape-examples to be a target-level configuration (rust-lang/cargo#10343 )
- temporarily disable test `lto::test_profile` (rust-lang/cargo#11419 )
2022-11-27 03:02:08 +00:00
bors
8681d4cffc
Auto merge of #104902 - matthiaskrgr:rollup-oo27a4u, r=matthiaskrgr
...
Rollup of 8 pull requests
Successful merges:
- #104716 (move 2 candidates into builtin candidate)
- #104760 (Clarify `SyntaxExtensionKind::LegacyDerive`.)
- #104797 (rustc_codegen_ssa: write `.dwp` in a streaming fashion)
- #104835 (Use infcx.partially_normalize_associated_types_in)
- #104853 (Fix typo in miri sysroot)
- #104879 (jsondoclint: Recognise Typedef as valid kind for Type::ResolvedPath)
- #104887 (rustbuild: Don't build doc::SharedAssets when building JSON docs.)
- #104896 (rustdoc: fix broken tooltip CSS)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
2022-11-25 19:09:30 +00:00
Matthias Krüger
12e1b84e95
Rollup merge of #104896 - notriddle:notriddle/tooltip, r=GuillaumeGomez
...
rustdoc: fix broken tooltip CSS
text `#ffffff` on background `#fdffd3` fails the [WCAG color contrast checker], and seems like a mistake in 16b55903ee .
Making the cursor a pointer is misleading, since clicking it doesn't do anything.
[WCAG color contrast checker]: https://accessibleweb.com/color-contrast-checker/
2022-11-25 18:35:42 +01:00
Matthias Krüger
c72db77ecb
Rollup merge of #104887 - aDotInTheVoid:rustbuild-json-doc-shared-assets, r=jyn514
...
rustbuild: Don't build doc::SharedAssets when building JSON docs.
Previously, running `./x doc library/core/ --json` on a plain build would panic bootstrap.
```
$ ./x doc library/core/ --json
Building rustbuild
Blocking waiting for file lock on package cache
Compiling bootstrap v0.0.0 (/home/nixon/dev/rust/rust/src/bootstrap)
Finished dev [unoptimized] target(s) in 4.47s
thread 'main' panicked at 'fs::write(&version_info, &info) failed with No such file or directory (os error 2) ("/home/nixon/dev/rust/rust/build/x86_64-unknown-linux-gnu/doc/version_info.html")', doc.rs:410:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Build completed unsuccessfully in 0:00:04
```
Becuase the `SharedAssets` step assumes that the HTML out dir has been created. This isn't true for JSON.
The fix is to not build shared assets when doing a JSON doc build, as it doesn't need them.
r? ``@jyn514``
``@rustbot`` modify labels: +A-rustdoc-json
2022-11-25 18:35:42 +01:00
Matthias Krüger
996de3adf6
Rollup merge of #104879 - aDotInTheVoid:jsondoclint-typedef, r=GuillaumeGomez
...
jsondoclint: Recognise Typedef as valid kind for Type::ResolvedPath
Closes #104851
r? ``@GuillaumeGomez``
``@rustbot`` modify labels: +A-testsuite
2022-11-25 18:35:42 +01:00
Matthias Krüger
287bb6d252
Rollup merge of #104853 - jyn514:sysroot-typo, r=RalfJung
...
Fix typo in miri sysroot
r? ``@RalfJung``
2022-11-25 18:35:41 +01:00
Matthias Krüger
7fac5048c4
Rollup merge of #104835 - spastorino:use-partially_normalize_associated_types_in, r=lcnr
...
Use infcx.partially_normalize_associated_types_in
r? ``@lcnr``
2022-11-25 18:35:41 +01:00
Matthias Krüger
aec60c6b7c
Rollup merge of #104797 - weihanglo:stream-write-dwp, r=jackh726
...
rustc_codegen_ssa: write `.dwp` in a streaming fashion
When writing a `.dwp` file, rustc writes to a Vec first then to a BufWriter-wrapped file. It seems very likely that we can write in a streaming fashion to avoid double buffering in an intermediate Vec.
On my Linux machine, `.dwp` from the latest rust-lang/cargo is 113MiB. It may worth a stream writer, though I didn't do any benchmark 🙇🏾♂️ .
2022-11-25 18:35:40 +01:00
Matthias Krüger
8f3f4980b4
Rollup merge of #104760 - nnethercote:rm-LegacyDerive, r=petrochenkov
...
Clarify `SyntaxExtensionKind::LegacyDerive`.
It's always treated the same as `SyntaxExtensionKind::Derive`.
2022-11-25 18:35:39 +01:00
Matthias Krüger
9c7dc3e30b
Rollup merge of #104716 - lcnr:selection-candidate, r=jackh726
...
move 2 candidates into builtin candidate
having separate candidates for these isn't too helpful i think
r? types
2022-11-25 18:35:39 +01:00
Michael Howell
75e4de61d4
rustdoc: revert tooltip background color on light theme to readable
...
text #fff on background #fdffd3 fails the [WCAG color contrast checker], and
seems like a mistake in 16b55903ee .
[WCAG color contrast checker]: https://accessibleweb.com/color-contrast-checker/
2022-11-25 09:28:25 -07:00
Michael Howell
f8b2e13d16
rustdoc: remove cursor: pointer from unclickable tooltip
...
It's misleading unless it gets changed to respond to being clicked.
2022-11-25 09:16:27 -07:00
bors
051cab2b84
Auto merge of #104846 - spastorino:santa-clauses-make-goals-early-christmas- 🎄 , r=oli-obk
...
Branch Clause from Predicate
r? `@oli-obk`
This is part of what's proposed in https://github.com/rust-lang/compiler-team/issues/531
2022-11-25 15:59:31 +00:00
Nixon Enraght-Moony
37b0a100aa
rustbuild: Don't build doc::SharedAssets when building JSON docs.
2022-11-25 13:50:41 +00:00
bors
e704e95250
Auto merge of #104877 - matthiaskrgr:rollup-s7taiq8, r=matthiaskrgr
...
Rollup of 6 pull requests
Successful merges:
- #103648 (Don't set `is_preview` for clippy and rustfmt)
- #104654 (Add `#![deny(unsafe_op_in_unsafe_fn)]` in liballoc tests)
- #104793 (unstable-book: Add page for the `abi_efiapi` feature)
- #104841 (Assert that we don't capture escaping bound vars in `Fn` trait selection)
- #104849 (Migrate source code elements style to CSS variables)
- #104873 (RefCell::get_mut: fix typo)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
2022-11-25 13:01:45 +00:00
lcnr
84e97907c6
add comment
2022-11-25 11:59:08 +01:00
lcnr
31431ccda9
move 2 candidates into builtin candidate
2022-11-25 11:59:08 +01:00
Nixon Enraght-Moony
eac8921ccf
jsondoclint: Recognise Typedef as valid kind for Type::ResolvedPath
...
Closes #104851
2022-11-25 10:53:14 +00:00
Matthias Krüger
f360686ed6
Rollup merge of #104873 - RalfJung:therefore, r=Dylan-DPC
...
RefCell::get_mut: fix typo
and fix the same typo in a bunch of other places
2022-11-25 10:44:40 +01:00
Matthias Krüger
8babe1c417
Rollup merge of #104849 - GuillaumeGomez:source-code-sidebar-css-migration, r=notriddle
...
Migrate source code elements style to CSS variables
r? ``@notriddle``
2022-11-25 10:44:40 +01:00
Matthias Krüger
34f1de8395
Rollup merge of #104841 - compiler-errors:fishy-bound-var, r=jackh726
...
Assert that we don't capture escaping bound vars in `Fn` trait selection
Fixes #104825
2022-11-25 10:44:39 +01:00
Matthias Krüger
f00c3f05bc
Rollup merge of #104793 - nicholasbishop:bishop-add-efiapi, r=JohnTitor
...
unstable-book: Add page for the `abi_efiapi` feature
Tracking issue for `abi_efiapi`: https://github.com/rust-lang/rust/issues/65815
2022-11-25 10:44:39 +01:00
Matthias Krüger
808157bd7d
Rollup merge of #104654 - thomcc:alloc-tests-unsafe_op_in_unsafe_fn, r=Mark-Simulacrum
...
Add `#![deny(unsafe_op_in_unsafe_fn)]` in liballoc tests
In https://github.com/rust-lang/rust/pull/104647#discussion_r1027332930 it was mentioned that liballoc tests should probably have this enabled (we have it pretty much everywhere else in the stdlib), so I added it.
This will probably conflict with https://github.com/rust-lang/rust/pull/104647 so I'll rebase after that lands.
2022-11-25 10:44:38 +01:00
Matthias Krüger
a9313e9077
Rollup merge of #103648 - jyn514:no-preview, r=Mark-Simulacrum
...
Don't set `is_preview` for clippy and rustfmt
These have been shipped on stable for many years now and it would be very disruptive to ever remove them.
Remove the `-preview` suffix from their dist components.
Based on https://github.com/rust-lang/rust/pull/102565 .
2022-11-25 10:44:37 +01:00
bors
8a75c5a9b5
Auto merge of #104650 - BlackHoleFox:stuck-with-xcode-13, r=Mark-Simulacrum
...
Build macOS distribution artifacts with XCode 13
After all of the `rust-lang/rust` Apple runners started using macOS 12, the builds created by CI began to use XCode 14.0.1. Due to this (as far as we can tell), XCode's build tools started to ignore the `MACOSX_DEPLOYMENT_TARGET` being defined by us for the distributed builds that let both `rustc` and `libstd` work on older versions. The current idea is that since XCode 14's macOS SDK doesn't support deployment targets before 10.13, it uses some default of its own. You can see the difference between stable's and the most recent nighty's supported versions [here](https://github.com/rust-lang/rust/issues/104570#issuecomment-1321225907 ).
I wasn't able to confirm my SDK versioning hypothesis locally since I think there's something jammed with my XCode installation, but hopefully this should still fix it for releases.
Closes https://github.com/rust-lang/rust/issues/104570
r? `@Mark-Simulacrum`
2022-11-25 09:44:16 +00:00
Ralf Jung
6ed4f15940
RefCell::get_mut: fix typo
...
and fix the same typo in a bunch of other places
2022-11-25 08:52:06 +01:00
bors
41e0363055
Auto merge of #104602 - petrochenkov:effvisperf5, r=oli-obk
...
privacy: Fix more (potential) issues with effective visibilities
Continuation of https://github.com/rust-lang/rust/pull/103965 .
See individual commits for more detailed description of the changes.
The shortcuts removed in https://github.com/rust-lang/rust/pull/104602/commits/4eb63f618e601efee657d24cd4e8833fb03fac4c and https://github.com/rust-lang/rust/pull/104602/commits/c7c7d1672739e38c8d39ae861b284486aefd5b48 could actually be correct (or correct after some tweaks), but they used global reasoning like "we can skip this update because if the code compiles then some other update should do the same thing eventually".
I have some expertise in this area, but I still have doubt whether such global reasoning was correct or not, especially in presence of all possible exotic cases with imports.
After this PR all table changes should be "locally correct" after every update, even if it may be overcautious.
If similar optimizations are introduced again they will need detailed comments explaining why it's legal to do what they do and providing proofs.
Fixes https://github.com/rust-lang/rust/issues/104249 .
Fixes https://github.com/rust-lang/rust/issues/104539 .
2022-11-25 06:14:42 +00:00
bors
af63e3b39f
Auto merge of #104855 - thomcc:revert-noinline-wintls, r=ChrisDenton
...
Revert "Forbid inlining `thread_local!`'s `__getit` function on Windows"
Revert of #101368 , fixes #104852 .
I'd rather not do this since that's a soundness fix and this is hitting some compiler bug, but I don't really know an alternative.
r? `@ChrisDenton`
2022-11-25 03:17:25 +00:00
Santiago Pastorino
974e2837bb
Introduce PredicateKind::Clause
2022-11-25 00:04:54 -03:00
Oli Scherer
42cc8e8f4e
Simplify a bunch of trait ref obligation creations
2022-11-25 00:04:54 -03:00
Oli Scherer
08afabddac
get rid of to_poly_trait_predicate
2022-11-25 00:04:52 -03:00
Thom Chiovoloni
24712f9982
Revert "Forbid inlining thread_local!'s __getit function on Windows"
...
This reverts commit 3099dfdd9f .
2022-11-24 18:12:12 -08:00
Joshua Nelson
99d080dc3c
Fix typo in miri sysroot
2022-11-24 20:28:55 -05:00
Joshua Nelson
fb3e724d76
Don't set is_preview for clippy and rustfmt
...
These have been shipped on stable for many years now and it would be very disruptive to ever remove them.
Remove the `-preview` suffix from their dist components.
2022-11-24 20:22:08 -05:00
bors
65a6e22668
Auto merge of #104845 - matthiaskrgr:rollup-tckj956, r=matthiaskrgr
...
Rollup of 11 pull requests
Successful merges:
- #104514 (Use node_ty_opt to avoid ICE in visit_ty)
- #104704 (Allow power10-vector feature in PowerPC)
- #104747 (resolve: Don't use constructor def ids in the map for field names)
- #104773 (OpaqueCast projections are always overlapping, they can't possibly be disjoint)
- #104774 (Document split{_ascii,}_whitespace() for empty strings)
- #104780 (make `error_reported` check for delayed bugs)
- #104782 (Bump the const eval step limit)
- #104792 (rustdoc: simplify `.search-results-title` CSS)
- #104796 (lint: do not warn unused parens around higher-ranked function pointers)
- #104820 (Remove normalize_projection_type)
- #104822 (with_query_mode -> new)
Failed merges:
- #104716 (move 2 candidates into builtin candidate)
- #104841 (Assert that we don't capture escaping bound vars in `Fn` trait selection)
r? `@ghost`
`@rustbot` modify labels: rollup
2022-11-24 23:45:32 +00:00
Guillaume Gomez
e6a4008d24
Strenghten GUI test to include extra state in selector
2022-11-24 23:39:49 +01:00
Guillaume Gomez
6fc52c6b80
Extend GUI test to include more source code elements checks
2022-11-24 23:36:41 +01:00
Guillaume Gomez
786ec7ccf1
Migrate source code elements style to CSS variables
2022-11-24 23:36:26 +01:00
Nicholas Nethercote
2c5d3705ec
Clarify SyntaxExtensionKind::LegacyDerive.
2022-11-25 09:13:27 +11:00
Michael Goulet
d945967779
Remove comment, simplify since we asserted fn ptr Self type has no bound vars
2022-11-24 21:50:04 +00:00
Michael Goulet
c7330c9fe8
Also check that fn pointer candidates don't have escaping bound vars
2022-11-24 21:50:04 +00:00
Michael Goulet
8927135274
Assert that we don't capture escaping bound vars in Fn trait selection
2022-11-24 21:50:04 +00:00
Matthias Krüger
1048a85dbe
Rollup merge of #104822 - spastorino:selctx-new-instead-of-with_query_mode, r=lcnr
...
with_query_mode -> new
r? ```@lcnr```
2022-11-24 21:34:57 +01:00
Matthias Krüger
73f01ffd46
Rollup merge of #104820 - spastorino:remove-normalize_projection_type, r=jackh726
...
Remove normalize_projection_type
r? ``@lcnr``
2022-11-24 21:34:56 +01:00
Matthias Krüger
83d1aab9ff
Rollup merge of #104796 - notriddle:notriddle/unused-issue-104397, r=oli-obk
...
lint: do not warn unused parens around higher-ranked function pointers
Fixes #104397
2022-11-24 21:34:56 +01:00
Matthias Krüger
ed2d9369f4
Rollup merge of #104792 - notriddle:notriddle/crate-search-title-display, r=GuillaumeGomez
...
rustdoc: simplify `.search-results-title` CSS
By using `display: flex`, we still get the never-wrapping layout with `#crate-search-div` maxing out and truncating its text. The title itself winds up always filling its parent, but since `#crate-search` doesn't have `flex-grow` set, it won't fill available space.
2022-11-24 21:34:55 +01:00
Matthias Krüger
679f1b7892
Rollup merge of #104782 - oli-obk:const_eval_limit_bump, r=pnkfelix
...
Bump the const eval step limit
fixes https://github.com/rust-lang/rust/issues/103814
https://github.com/rust-lang/rust/pull/103877 has too much of an impact to beta backport. So let's just increase the limit, avoiding the immediate breakage.
r? ``@pnkfelix``
2022-11-24 21:34:55 +01:00
Matthias Krüger
4843946a10
Rollup merge of #104780 - BoxyUwU:error_reported_not_be_bad, r=oli-obk
...
make `error_reported` check for delayed bugs
Fixes #104768
`error_reported()` was only checking if there were errors emitted, not for `delay_bug`s which can also be a source of `ErrorGuaranteed`. I assume the same is true of `lint_err_count` but i dont know
2022-11-24 21:34:54 +01:00
Matthias Krüger
d4e5418b0c
Rollup merge of #104774 - vojtechkral:doc-str-empty-split-whitespace, r=thomcc
...
Document split{_ascii,}_whitespace() for empty strings
doc change only
2022-11-24 21:34:54 +01:00
Matthias Krüger
9a558b68e1
Rollup merge of #104773 - oli-obk:overlap, r=lcnr
...
OpaqueCast projections are always overlapping, they can't possibly be disjoint
r? ``@lcnr``
2022-11-24 21:34:53 +01:00