Chayim Refael Friedman
23a3e642d7
Merge pull request #21648 from alexanderkjall/borsh-error-compilation-failure
...
fix smol_str compilation error
2026-02-15 16:42:02 +00:00
Chayim Refael Friedman
5ad533b09c
Merge pull request #21649 from Albab-Hasan/fix/assignment-rhs-never-coercion
...
fix: use `ExprIsRead::Yes` for rhs of ordinary assignments
2026-02-15 14:16:24 +00:00
Albab-Hasan
7733f65ff9
fix: use ExprIsRead::Yes for rhs of ordinary assignments
...
the rhs of an ordinary assignment `x = *never_ptr` was inferred with
`ExprIsRead::No`, which prevented `NeverToAny` coercion for place
expressions of type `!`. this caused false type mismatches and missing
divergence detection. the destructuring assignment path and let binding
path both correctly use `ExprIsRead::Yes` for the rhs value, since the
value is always consumed (read). this makes the ordinary assignment path
consistent with both.
2026-02-15 17:37:51 +06:00
Chayim Refael Friedman
721edae2f9
Merge pull request #21647 from Albab-Hasan/fix/contains-explicit-ref-binding-missing-refmut
...
fix: handle `ref mut` bindings in `contains_explicit_ref_binding`
2026-02-15 11:36:30 +00:00
Alexander Kjäll
8d3b9f4a81
gate borsh tests on std also, as they depend on both
2026-02-15 10:28:47 +01:00
Albab-Hasan
646418838f
fix: handle ref mut bindings in contains_explicit_ref_binding
...
the standalone `contains_explicit_ref_binding` function only checked for
`BindingAnnotation::Ref`, missing `BindingAnnotation::RefMut`. this caused
`let ref mut x = expr` to incorrectly take the coercion path instead of
preserving the exact type of the rhs expression. the method version used
for match arms already handles both `Ref` and `RefMut` correctly.
2026-02-15 04:21:34 +06:00
Alexander Kjäll
d15d7149b1
fix smol_str compilation error
...
the command 'cargo build --no-default-features --features borsh' failed with:
error[E0599]: no function or associated item named 'other' found for struct 'borsh::io::Error' in the current scope
--> lib/smol_str/src/borsh.rs:33:39
|
33 | .ok_or_else(|| Error::other("u8::vec_from_reader unexpectedly returned None"))?;
| ^^^^^ function or associated item not found in 'borsh::io::Error'
|
2026-02-14 21:06:34 +01:00
Lukas Wirth
deaae4956d
Merge pull request #21639 from rust-lang/dependabot/npm_and_yarn/editors/code/qs-6.14.2
...
build(deps): bump qs from 6.14.1 to 6.14.2 in /editors/code
2026-02-14 07:55:56 +00:00
Lukas Wirth
81b72755bd
Merge pull request #21644 from Veykril/push-zrzoswxlqlqq
...
Revert "fix: Stale diagnostics with rust-project.json and rustc JSON"
2026-02-13 18:28:52 +00:00
Lukas Wirth
a9cc42e576
Revert "fix: Stale diagnostics with rust-project.json and rustc JSON"
...
This reverts commit 2cefe47e6d55c186b68687bf677bf0d5eb65a922.
2026-02-13 19:19:26 +01:00
Lukas Wirth
ca35562cd3
Merge pull request #21640 from Veykril/push-rutrqvxousks
...
minor: Remove incorrect warning log
2026-02-13 15:33:46 +00:00
Lukas Wirth
da9ff14a13
Remove incorrect warning log
2026-02-13 16:24:28 +01:00
dependabot[bot]
c2c7d5d7ef
build(deps): bump qs from 6.14.1 to 6.14.2 in /editors/code
...
Bumps [qs](https://github.com/ljharb/qs ) from 6.14.1 to 6.14.2.
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/ljharb/qs/compare/v6.14.1...v6.14.2 )
---
updated-dependencies:
- dependency-name: qs
dependency-version: 6.14.2
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
2026-02-13 11:43:39 +00:00
Lukas Wirth
4b5b181935
Merge pull request #21609 from Veykril/push-qknzslvkmtyt
...
internal: Use rayon for proc-macro loading
2026-02-13 11:33:11 +00:00
Lukas Wirth
b132beb7e0
internal: Use rayon for proc-macro loading
2026-02-13 12:24:47 +01:00
Shoyu Vanilla (Flint)
f931a79a2a
Merge pull request #21633 from ChayimFriedman2/proc-macro-is-not-fn
...
fix: Do not resolve proc macros in value ns (as functions), only in macro ns, outside their defining crate
2026-02-13 08:47:17 +00:00
Shoyu Vanilla (Flint)
6040177bfb
Merge pull request #21636 from Shourya742/2026-02-13-remove-edit-in-place-in-migrated-handlers
...
Remove mutable edit in place with edit::AstNodeEdit in migrated assist handlers
2026-02-13 08:45:05 +00:00
bit-aloo
c6b1f8ad9a
remove edit_in_place from generate_new assist with edit::AstNodeEdit
2026-02-13 13:14:06 +05:30
bit-aloo
85e0c3209e
remove edit_in_place from convert_bool_to_enum assist with edit::AstNodeEdit
2026-02-13 13:11:46 +05:30
bit-aloo
140a039fb7
remove edit_in_place from generate_trait_from_impl assist with edit::AstNodeEdit
2026-02-13 13:09:27 +05:30
bit-aloo
c8e284bf01
remove edit_in_place from replace_if_let_with_match assist with edit::AstNodeEdit
2026-02-13 13:01:50 +05:30
bit-aloo
96d6a3e077
remove edit_in_place from convert_let_else_to_match assist with edit::AstNodeEdit
2026-02-13 12:20:42 +05:30
bit-aloo
34eee0c30a
remove edit_in_place from generate_getter_or_setter assist with edit::AstNodeEdit
2026-02-13 12:16:50 +05:30
bit-aloo
5de304e2a4
remove edit_in_place from generate_mut_trait_impl assist with edit::AstNodeEdit
2026-02-13 12:15:47 +05:30
bit-aloo
6221b39591
remove edit_in_place from bind_unused_param assist with edit::AstNodeEdit
2026-02-13 12:13:35 +05:30
bit-aloo
28bf2dbb13
remove edit_in_place from move_const_to_impl assist with edit::AstNodeEdit
2026-02-13 12:11:19 +05:30
bit-aloo
3a202c4736
remove edit_in_place from replace_let_with_if_let assist with edit::AstNodeEdit
2026-02-13 12:07:01 +05:30
Chayim Refael Friedman
b76642de15
Cleanup unnecessary code
2026-02-13 00:31:51 +02:00
Chayim Refael Friedman
4fc780d97c
Do not resolve proc macros in value ns (as functions), only in macro ns, outside their defining crate
...
The main impact is that syntax highlighting will show it as a macro and not a function.
2026-02-13 00:26:49 +02:00
Shoyu Vanilla (Flint)
b214aac14c
Merge pull request #21632 from ChayimFriedman2/extern-fn-pat
...
fix: Don't assume `extern fn`s parameters are patterns
2026-02-12 22:14:37 +00:00
Chayim Refael Friedman
61df37fafa
Don't assume extern fns parameters are patterns
...
Unlike normal fns, they should be bare identifiers.
2026-02-12 23:17:55 +02:00
Chayim Refael Friedman
15e661ce61
Merge pull request #21381 from A4-Tacks/inline-call-generic-args
...
Fix incorrect Self path expand for inline_call
2026-02-12 20:57:11 +00:00
Chayim Refael Friedman
88d951e251
Merge pull request #21402 from A4-Tacks/no-semicolon-array
...
Fix complete semicolon in array expression
2026-02-12 20:10:46 +00:00
Chayim Refael Friedman
860469f758
Merge pull request #21591 from A4-Tacks/hover-fmt-long-param
...
feat: Improve hover too long parameter list
2026-02-12 19:58:33 +00:00
Shoyu Vanilla (Flint)
5bbd3e65dc
Merge pull request #21619 from Shourya742/2026-02-10-migrate-convert-tuple-return-type-to-struct
...
migrate covert_tuple_return_type to struct assist to syntax editor
2026-02-12 09:31:47 +00:00
Chayim Refael Friedman
c991d070bd
Merge pull request #21627 from rust-lang/revert-21380-push-nolvxuourwru
...
Revert "feat: Implement fine grained client side request cancellation support"
2026-02-12 09:29:22 +00:00
bit-aloo
9c468be363
move to edit::AstNodeEdit from edit_in_place::Indent
2026-02-12 14:52:48 +05:30
bit-aloo
87feb37bc7
migrate covert_tuple_return_type to struct to syntax editor
2026-02-12 14:52:48 +05:30
Chayim Refael Friedman
8b27b45bbd
Revert "feat: Implement fine grained client side request cancellation support"
2026-02-12 11:20:27 +02:00
Chayim Refael Friedman
d32a47377e
Merge pull request #21628 from Shourya742/2026-02-12-pin-nightly-for-miri-workflow
...
Pin nightly for miri workflow
2026-02-12 09:08:22 +00:00
bit-aloo
11ce0a5655
pin nightly for miri workflow
2026-02-12 14:03:22 +05:30
Lukas Wirth
eb05ff6068
Merge pull request #21581 from Wilfred/clippy_in_ci
...
internal: Run clippy as a separate CI step
2026-02-11 16:57:18 +00:00
Shoyu Vanilla (Flint)
49228dc09f
Merge pull request #21618 from Shourya742/2026-02-10-migrate-destructure-tuple-binding-to-syntaxeditor
...
Migrate destructure tuple binding assist to syntaxEditor
2026-02-11 10:07:04 +00:00
Shoyu Vanilla (Flint)
751508a968
Merge pull request #21507 from Shourya742/2026-01-17-migrate-named-lifetime
...
migrate introduce_named_lifetime assist to SyntaxEditor
2026-02-11 10:01:45 +00:00
bit-aloo
9c7cc62406
make generate_unique_lifetime_param_name return Option<SmolStr>
2026-02-11 15:23:09 +05:30
bit-aloo
78c8ab35e8
migrate destructure tuple binding to new syntaxEditor
2026-02-11 13:39:13 +05:30
Shoyu Vanilla (Flint)
c53e819a2c
Merge pull request #21583 from A4-Tacks/derive-manual-assoc-bounds
...
fix: Fix loses associated bounds for replace_derive_with_manual_impl
2026-02-10 05:56:14 +00:00
Chayim Refael Friedman
68f2f3cd7f
Merge pull request #21611 from ShoyuVanilla/issue-21605
...
fix: Sync `allow_normalization` to rustc
2026-02-09 20:14:10 +00:00
A4-Tacks
5a721a117f
Improve variable name
2026-02-10 04:14:09 +08:00
Chayim Refael Friedman
a3b7fa9d21
Merge pull request #21584 from regexident/def-with-body-types
...
Add `expression_types()`, `pattern_types()`, `binding_types()` to `DefWithBody`
2026-02-09 20:13:16 +00:00