Lukas Wirth
3309dfa090
Merge pull request #18702 from ChayimFriedman2/prep
...
minor: Use a record struct instead of a tuple for each namespace in `PerNs`
2024-12-20 11:05:49 +00:00
Lukas Wirth
4200da43cf
Merge pull request #18726 from Veykril/push-vyzotyqqtpqs
...
fix: Reduce applicability of unnecessary_async assist
2024-12-20 07:56:23 +00:00
Lukas Wirth
a1924e85f6
fix: Reduce applicability of unnecessary_async assist
2024-12-20 08:41:46 +01:00
Lukas Wirth
4f03dd9d58
Merge pull request #18717 from Veykril/push-pomxnvxotwlr
...
internal: Set `result_id` for pull diagnostics
2024-12-19 15:38:32 +00:00
Lukas Wirth
1930075c26
internal: Set result_id for pull diagnostics
2024-12-19 16:24:18 +01:00
Lukas Wirth
4aa34abe64
Merge pull request #18715 from aibaars/ungram-asm-option
...
Fix AsmOption rule in rust.ungram
2024-12-18 14:22:05 +00:00
Lukas Wirth
84dd3cb9c0
Merge pull request #18716 from Veykril/push-lyxuzrnkmklp
...
fix: Consider both completion detail fields in to_proto
2024-12-18 14:14:39 +00:00
Lukas Wirth
29fc82d9d4
fix: Consider both completion detail fields in to_proto
2024-12-18 15:00:09 +01:00
Arthur Baars
950a7504f3
Fix AsmOption rule in rust.ungram
2024-12-18 14:56:00 +01:00
Lukas Wirth
4db0f680bd
Merge pull request #18714 from Veykril/push-krxvsqwrokwp
...
fix: Do not ask the client to resolve for non existing label details
2024-12-18 13:24:53 +00:00
Lukas Wirth
11536cc584
fix: Do not ask the client ro resolve for non existing label details
2024-12-18 14:03:50 +01:00
Lukas Wirth
20bc7533c4
Merge pull request #18713 from Veykril/push-zmmkzspnwxsn
...
internal: Cleanup label structure of `CompletionItem`
2024-12-18 12:53:07 +00:00
Lukas Wirth
51055135e6
internal: Cleanup label structure of CompletionItem
2024-12-18 13:37:21 +01:00
Lukas Wirth
88be63a95b
Merge pull request #18711 from Veykril/push-kwurwxttmqwo
...
Taking a raw ref of a deref is always safe
2024-12-18 10:47:07 +00:00
Lukas Wirth
b2b95f0502
Taking a raw ref of a deref is always safe
2024-12-18 11:32:29 +01:00
Lukas Wirth
ff97582c64
Merge pull request #18710 from Veykril/push-oywuruktpozm
...
Remove salsa from proc-macro server dep tree
2024-12-18 09:38:49 +00:00
Lukas Wirth
f01874cbed
Remove salsa from proc-macro server dep tree
2024-12-18 10:24:26 +01:00
Lukas Wirth
45f3da589c
Merge pull request #18708 from ChayimFriedman2/fix-tiny
...
fix: Fix pretty-printing of `@` patterns
2024-12-18 07:41:09 +00:00
Chayim Refael Friedman
716673ce9f
Fix pretty-printing of @ patterns
...
It didn't print the `@`.
2024-12-18 01:24:12 +02:00
Lukas Wirth
7f45fedec5
Merge pull request #18700 from ChayimFriedman2/dyn-send
...
fix: Fix a panic with a diagnostics fix when a keyword is used as a field
2024-12-16 21:54:28 +00:00
Chayim Refael Friedman
cf32a6fecc
Use a record struct instead of a tuple for each namespace in PerNs
...
The reason I did this is because I plan to add another field to this struct (indicating whether the item was cfg'ed out), but it seems worthy even separately and removes a bunch of one-letter variable names and tuple-indexing. It is also easy to separate from future changes, so it will be easier to review this way.
2024-12-16 22:39:50 +02:00
Chayim Refael Friedman
536318c9da
Fix a panic with a diagnostics fix when a keyword is used as a field
...
I found it easiest to fix in the quickfix code, and not deeper (e.g. body lowering).
2024-12-16 19:58:29 +02:00
Lukas Wirth
0e81d18dde
Merge pull request #18699 from Veykril/push-ltqwwusvtlot
...
fix: Fix path qualified auto-importing completions not working with re-exports
2024-12-16 12:34:59 +00:00
Lukas Wirth
9fc5ceff0e
fix: Fix path qualified auto-importing completions not working with re-exports
...
Prior to this commit we used to generate import paths, then zipped them with the existing qualifier to check if they agree on the path to import.
This is brittle when re-exports come into play causing items to have multiple applicable paths that refer to them.
This commit instead rewrites this logic by generating the import path for the qualifier, verifying that the rest of the qualifier resolves and then doing a final lookup on that resolution result for the final segment instead.
2024-12-16 13:20:55 +01:00
Lukas Wirth
7980b811f0
Merge pull request #18698 from Veykril/push-vpqwrwxptsql
...
internal: Don't serialize empty fields in completions and resolve payloads
2024-12-16 10:39:19 +00:00
Lukas Wirth
471766221a
Merge pull request #18690 from Giga-Bowser/extract-variable-string
...
feat: Use string literal contents as a name when extracting into variable
2024-12-16 10:29:05 +00:00
Lukas Wirth
5c678215dd
internal: Don't serialize empty fields in completions and resolve payloads
2024-12-16 11:25:29 +01:00
Lukas Wirth
99a4592170
Merge pull request #18695 from roife/improve-tuple-destruction
...
minor: improve name suggestion for destructure_tuple_binding
2024-12-16 10:25:01 +00:00
Lukas Wirth
dd094101bd
Merge pull request #18696 from ChayimFriedman2/syn-syn
...
feat: Report unresolved idents for implicit captures in `format_args!()`
2024-12-16 09:33:51 +00:00
Lukas Wirth
4c52ed4286
Merge pull request #18697 from Veykril/push-qtmmtvpyrntr
...
internal: Simplify ratoml testdir usage
2024-12-16 09:16:18 +00:00
Lukas Wirth
1cace0aa41
internal: Simplify ratoml testdir usage
2024-12-16 10:01:35 +01:00
Chayim Refael Friedman
ffe908d3ee
Report unresolved idents for implicit captures in format_args!()
...
And also a bit of cleanup by storing the capture's span with the open quote included.
2024-12-16 10:10:26 +02:00
roife
de555200f7
refactor: simplify edit_tuple_usages in destructure_tuple_binding
2024-12-16 14:12:19 +08:00
Laurențiu Nicola
5c6bae0fc0
Merge pull request #18693 from Veykril/push-wzoomkkmuolm
...
fix: Fix proc-macro dylib names on windows
2024-12-15 18:32:38 +00:00
Lukas Wirth
d501b3ca74
Merge pull request #18694 from Veykril/push-uxpuruvqpwmx
...
internal: Show mir eval errors on hover with debug env var set
2024-12-15 16:51:17 +00:00
Lukas Wirth
31a462f6e0
fix: Fix proc-macro dylib names on windows
2024-12-15 17:38:44 +01:00
Lukas Wirth
9e22cbf48b
internal: Show mir eval errors on hover with debug env var set
2024-12-15 17:38:37 +01:00
Giga Bowser
5e196f0741
feat: Use string literal contents as a name when extracting into variable
2024-12-14 13:36:57 -05:00
Laurențiu Nicola
97de6dce98
Merge pull request #18684 from Giga-Bowser/revert-client-changes
...
fix: Revert changes to client capabilities in `bac0ed5`
2024-12-13 20:30:33 +00:00
Giga Bowser
f69b6fc506
fix: Revert changes to client capabilities in bac0ed5
2024-12-13 11:59:50 -05:00
roife
4704a962e7
feat: improve name generation in destructure_tuple_binding
2024-12-13 23:34:03 +08:00
Laurențiu Nicola
2338efa91f
Merge pull request #18681 from lnicola/bump-typos
...
minor: Bump typos
2024-12-13 10:00:23 +00:00
Laurențiu Nicola
9847e01377
Bump typos
2024-12-13 11:45:44 +02:00
Laurențiu Nicola
326a2e5724
Merge pull request #18678 from regexident/fix-typos
...
minor: Fix a few typos
2024-12-13 09:09:33 +00:00
Vincent Esche
c8abe14dd7
Fix a few typos
2024-12-13 09:54:35 +01:00
Lukas Wirth
6c1138e05a
Merge pull request #18674 from Veykril/push-lrxotqknvxvr
...
Show expansion errors in expand_macro feature
2024-12-13 08:50:45 +00:00
Lukas Wirth
7718173520
Merge pull request #18672 from Veykril/push-lurnqpqtzvzq
...
internal: Do not require a special env var to be set for the proc-macro-srv
2024-12-13 08:43:33 +00:00
Lukas Wirth
3a83938956
Show expansion errors in expand_macro feature
2024-12-13 09:36:03 +01:00
Lukas Wirth
54f467b68d
Do not require a special env var to be set for the proc-macro-srv
2024-12-13 09:29:16 +01:00
Lukas Wirth
c57aec8d58
Merge pull request #18677 from Veykril/push-uumpxklsqpzk
...
internal: Implement `naked_asm!` builtin
2024-12-12 16:58:26 +00:00