Lukas Wirth
7bd85e99bd
Merge pull request #18741 from Veykril/push-nuqmzsrrltux
...
fix: Delay initial flycheck until after build scripts
2024-12-22 13:32:48 +00:00
Lukas Wirth
eea63c2473
fix: Delay initial flycheck until after build scripts
2024-12-22 14:18:53 +01:00
Lukas Wirth
c38d297b9f
Merge pull request #18738 from Veykril/push-vqxqutskzvvu
...
fix: Properly check if workspace flychecking is allowed
2024-12-22 12:11:00 +00:00
Lukas Wirth
84b7c8b13c
Merge pull request #18740 from Veykril/push-tntsvtmtlotw
...
fix: Fix empty check diagnostics not marking files as changed
2024-12-22 11:52:59 +00:00
Lukas Wirth
2a977e0e92
fix: Fix empty check diagnostics not marking files as changed
2024-12-22 12:38:38 +01:00
Lukas Wirth
36135264a6
Merge pull request #18739 from Veykril/push-ntpvvqnnovtn
...
fix: Don't trigger paren wrapping typing handler after idents
2024-12-22 11:22:56 +00:00
Lukas Wirth
b08d1f93ce
fix: Properly check if workspace flychecking is allowed
2024-12-22 12:10:48 +01:00
Lukas Wirth
15206e4942
fix: Don't trigger paren wrapping typing handler after idents
2024-12-22 12:08:27 +01:00
Lukas Wirth
36455e9557
Merge pull request #18737 from Veykril/push-rslstwynmzpx
...
minor: Tell the server to stop prior to restarting it
2024-12-22 10:44:27 +00:00
Lukas Wirth
5c302cc867
minor: Tell the server to stop prior to restarting it
2024-12-22 11:30:18 +01:00
Lukas Wirth
9812c4de07
Merge pull request #18735 from Veykril/push-rpuxqrzrzvsw
...
fix: Set `result_id` for `RelatedFullDocumentDiagnosticReport` everywhere
2024-12-22 10:03:25 +00:00
Lukas Wirth
c2e2360d9b
fix: Set result_id for RelatedFullDocumentDiagnosticReport everywhere
2024-12-22 10:48:57 +01:00
Lukas Wirth
0c409e5a69
Merge pull request #18727 from roife/fix-issue-18704
...
fix: remove `always!` check for file_id in `runnables`
2024-12-21 07:10:08 +00:00
roife
56ced3b32f
fix: only show debug lens with a valid root
2024-12-21 07:03:45 +08:00
roife
4f754f4fe7
fix: remove always! check for file_id in runnables
2024-12-21 07:00:49 +08:00
Lukas Wirth
2d895a760e
Merge pull request #18731 from rust-lang/revert-18670-push-ylomnylswnxm
...
Revert "internal: Drop proc-macro server support for ~1.66.0 and older toolchains"
2024-12-20 20:06:24 +00:00
Lukas Wirth
b7bde823c0
Revert "internal: Drop proc-macro server support for ~1.66.0 and older toolchains"
2024-12-20 20:51:09 +01:00
Lukas Wirth
b694ff3d15
Merge pull request #18729 from Veykril/push-kyxtnozqzwkn
...
Clear flycheck diagnostics more granularly
2024-12-20 13:23:31 +00:00
Lukas Wirth
cb3eba1952
Clear all check diagnostics when the workspace changes
2024-12-20 14:09:29 +01:00
Lukas Wirth
bc5a260f99
Arc the package ids coming from flycheck
2024-12-20 14:09:29 +01:00
Lukas Wirth
3f786bb7d7
Arc the workspace root flycheck
2024-12-20 14:09:11 +01:00
Lukas Wirth
98fcc05183
Clear flycheck diagnostics more granularly
2024-12-20 14:09:11 +01:00
Lukas Wirth
df8b8ecf98
Merge pull request #18723 from ChayimFriedman2/tracing-complete
...
fix: Fix a case where completion was unable to expand a macro
2024-12-20 12:33:25 +00:00
Chayim Refael Friedman
0e266ae118
Fix a case where completion was unable to expand a macro
...
Which caused the macros of the popular `tracing` crate to not offer completions.
The reason is rather complicated: it boils down to macro ignoring their input and completion always choosing the first expansion.
2024-12-20 13:14:59 +02:00
Lukas Wirth
90c345bc9c
Merge pull request #18728 from Veykril/push-ozqlrzmqklwt
...
internal: Split `serde` derive feature into `serde_derive` usage
2024-12-20 11:09:27 +00:00
Lukas Wirth
3309dfa090
Merge pull request #18702 from ChayimFriedman2/prep
...
minor: Use a record struct instead of a tuple for each namespace in `PerNs`
2024-12-20 11:05:49 +00:00
Lukas Wirth
23e2f8aa86
internal: Split serde derive feature into serde_derive usage
...
Ideally we'd not have any dependency pull in the derive feature for faster build times, once that is the case this change would have an actual effect.
See https://github.com/matklad/macro-dep-test/blob/master/README.md for context.
2024-12-20 11:55:02 +01:00
Lukas Wirth
4200da43cf
Merge pull request #18726 from Veykril/push-vyzotyqqtpqs
...
fix: Reduce applicability of unnecessary_async assist
2024-12-20 07:56:23 +00:00
Lukas Wirth
a1924e85f6
fix: Reduce applicability of unnecessary_async assist
2024-12-20 08:41:46 +01:00
Lukas Wirth
4f03dd9d58
Merge pull request #18717 from Veykril/push-pomxnvxotwlr
...
internal: Set `result_id` for pull diagnostics
2024-12-19 15:38:32 +00:00
Lukas Wirth
1930075c26
internal: Set result_id for pull diagnostics
2024-12-19 16:24:18 +01:00
Lukas Wirth
4aa34abe64
Merge pull request #18715 from aibaars/ungram-asm-option
...
Fix AsmOption rule in rust.ungram
2024-12-18 14:22:05 +00:00
Lukas Wirth
84dd3cb9c0
Merge pull request #18716 from Veykril/push-lyxuzrnkmklp
...
fix: Consider both completion detail fields in to_proto
2024-12-18 14:14:39 +00:00
Lukas Wirth
29fc82d9d4
fix: Consider both completion detail fields in to_proto
2024-12-18 15:00:09 +01:00
Arthur Baars
950a7504f3
Fix AsmOption rule in rust.ungram
2024-12-18 14:56:00 +01:00
Lukas Wirth
4db0f680bd
Merge pull request #18714 from Veykril/push-krxvsqwrokwp
...
fix: Do not ask the client to resolve for non existing label details
2024-12-18 13:24:53 +00:00
Lukas Wirth
11536cc584
fix: Do not ask the client ro resolve for non existing label details
2024-12-18 14:03:50 +01:00
Lukas Wirth
20bc7533c4
Merge pull request #18713 from Veykril/push-zmmkzspnwxsn
...
internal: Cleanup label structure of `CompletionItem`
2024-12-18 12:53:07 +00:00
Lukas Wirth
51055135e6
internal: Cleanup label structure of CompletionItem
2024-12-18 13:37:21 +01:00
Lukas Wirth
88be63a95b
Merge pull request #18711 from Veykril/push-kwurwxttmqwo
...
Taking a raw ref of a deref is always safe
2024-12-18 10:47:07 +00:00
Lukas Wirth
b2b95f0502
Taking a raw ref of a deref is always safe
2024-12-18 11:32:29 +01:00
Lukas Wirth
ff97582c64
Merge pull request #18710 from Veykril/push-oywuruktpozm
...
Remove salsa from proc-macro server dep tree
2024-12-18 09:38:49 +00:00
Lukas Wirth
f01874cbed
Remove salsa from proc-macro server dep tree
2024-12-18 10:24:26 +01:00
Lukas Wirth
45f3da589c
Merge pull request #18708 from ChayimFriedman2/fix-tiny
...
fix: Fix pretty-printing of `@` patterns
2024-12-18 07:41:09 +00:00
Chayim Refael Friedman
716673ce9f
Fix pretty-printing of @ patterns
...
It didn't print the `@`.
2024-12-18 01:24:12 +02:00
Lukas Wirth
7f45fedec5
Merge pull request #18700 from ChayimFriedman2/dyn-send
...
fix: Fix a panic with a diagnostics fix when a keyword is used as a field
2024-12-16 21:54:28 +00:00
Chayim Refael Friedman
cf32a6fecc
Use a record struct instead of a tuple for each namespace in PerNs
...
The reason I did this is because I plan to add another field to this struct (indicating whether the item was cfg'ed out), but it seems worthy even separately and removes a bunch of one-letter variable names and tuple-indexing. It is also easy to separate from future changes, so it will be easier to review this way.
2024-12-16 22:39:50 +02:00
Chayim Refael Friedman
536318c9da
Fix a panic with a diagnostics fix when a keyword is used as a field
...
I found it easiest to fix in the quickfix code, and not deeper (e.g. body lowering).
2024-12-16 19:58:29 +02:00
Lukas Wirth
0e81d18dde
Merge pull request #18699 from Veykril/push-ltqwwusvtlot
...
fix: Fix path qualified auto-importing completions not working with re-exports
2024-12-16 12:34:59 +00:00
Lukas Wirth
9fc5ceff0e
fix: Fix path qualified auto-importing completions not working with re-exports
...
Prior to this commit we used to generate import paths, then zipped them with the existing qualifier to check if they agree on the path to import.
This is brittle when re-exports come into play causing items to have multiple applicable paths that refer to them.
This commit instead rewrites this logic by generating the import path for the qualifier, verifying that the rest of the qualifier resolves and then doing a final lookup on that resolution result for the final segment instead.
2024-12-16 13:20:55 +01:00
