Commit graph

303047 commits

Author SHA1 Message Date
Laurențiu Nicola
fefecbcd03
Merge pull request #20699 from lnicola/ena-fingerprint
minor: Set `WithCachedTypeInfo::stable_hash` when in-tree
2025-09-19 05:20:01 +00:00
Laurențiu Nicola
6870e24fdb Set WithCachedTypeInfo::stable_hash when in-tree 2025-09-19 08:08:23 +03:00
Shoyu Vanilla (Flint)
c68acff6eb
Merge pull request #20695 from ShoyuVanilla/fix-another-in-tree
fix: Fix one more thing in `in-rust-tree`
2025-09-18 19:34:53 +00:00
Shoyu Vanilla
01cd04f78d fix: Fix one more thing in in-rust-tree 2025-09-19 04:20:24 +09:00
Laurențiu Nicola
9348de05d7
Merge pull request #20694 from ShoyuVanilla/bump-rustc
minor: Yet another rustc crates bump
2025-09-18 18:38:03 +00:00
Shoyu Vanilla
3ba8b8e0e5 minor: Yet another rustc crates bump 2025-09-19 03:26:03 +09:00
Laurențiu Nicola
ddbfd3a1d8
Merge pull request #20693 from ShoyuVanilla/fix-indexmap-in-tree
fix: Fix `indexmap` with `in-rust-tree`
2025-09-18 18:16:41 +00:00
Shoyu Vanilla
60f0407ba3 fix: Fix indexmap with in-rust-tree 2025-09-19 03:04:14 +09:00
Shoyu Vanilla (Flint)
4f24cc65ee
Merge pull request #20691 from lnicola/bump-rustc-again
minor: Bump rustc crates again
2025-09-18 16:14:50 +00:00
Laurențiu Nicola
c6b4f6f33f Bump rustc crates again 2025-09-18 19:03:35 +03:00
Laurențiu Nicola
42466b57bb
Merge pull request #20690 from ShoyuVanilla/update-rustc
minor: Update rustc deps
2025-09-18 14:14:40 +00:00
Shoyu Vanilla
7e270ab27e chore: Update rustc deps 2025-09-18 23:02:42 +09:00
Chayim Refael Friedman
a520c46b89
Merge pull request #20664 from ChayimFriedman2/coerce-ns
fix: Port a bunch of stuff from rustc and fix a bunch of type mismatches/diagnostics
2025-09-18 00:19:30 +00:00
Shoyu Vanilla (Flint)
bb7cdc25d4
Merge pull request #20682 from A4-Tacks/fix-change-vis-applicable-on-variant
Fix applicable on variant field for change_visibility
2025-09-17 17:00:31 +00:00
A4-Tacks
28b0e4e15e
Fix applicable on variant field for change_visibility
Enum variant fields do not allow visibility

Example
---
```rust
enum Foo {
    Variant($0String),
}
```

**Before this PR**:

```rust
enum Foo {
    Variant(pub(crate) String),
}
```

**After this PR**:

Assist not applicable
2025-09-17 22:57:25 +08:00
Chayim Refael Friedman
171812726d
Merge pull request #20583 from btj/comments-enable
Add `rust-analyzer.semanticHighlighting.comments.enable`
2025-09-17 14:06:17 +00:00
Bart Jacobs
6e101637fa Add the rust-analyzer.semanticHighlighting.comments.enable configuration value 2025-09-17 15:46:23 +02:00
Chayim Refael Friedman
ad19341ea9
Merge pull request #20379 from skewb1k/fix/consistent-hover-doc-breaks
fix(hover): unify horizontal rule formatting to `---`
2025-09-17 02:02:48 +00:00
David Barsky
dfa11e7d61
Merge pull request #20677 from ShoyuVanilla/fix-ena
Fix "sync-from-ra" for `rust-lang/rust`
2025-09-16 18:36:41 +00:00
Shoyu Vanilla
f71f756695 Fix "sync-from-ra" for rust-lang/rust 2025-09-17 03:22:52 +09:00
Lukas Wirth
1b3c3a8f91
Merge pull request #20612 from Veykril/veykril/push-vzuykrsxvrts
fix: Fix expand macro recursively not working correctly for nested macro calls
2025-09-16 07:51:08 +00:00
Lukas Wirth
16feb8298e
Merge pull request #20402 from rust-lang/veykril/push-pursotqxutsx
Add more workaround hacks for incorrect startup diagnostics
2025-09-16 07:30:45 +00:00
Lukas Wirth
b4151f864b
Merge pull request #20517 from Veykril/veykril/push-wrurmtqppzus
fix: Only compute unstable paths on nightly toolchains for IDE features
2025-09-16 07:28:47 +00:00
Lukas Wirth
fd28cc8a1b Add more workaround hacks for incorrect startup diagnostics 2025-09-16 09:18:03 +02:00
Lukas Wirth
9699d35798 Workaround lsp-types typo 2025-09-16 09:17:38 +02:00
Lukas Wirth
8a9ec5dd0d fix: Only compute unstable paths on nightly toolchains for IDE features 2025-09-16 09:17:16 +02:00
Lukas Wirth
181bd119d0 fix: Fix expand macro recursively not working correctly for nested macro calls 2025-09-16 09:16:42 +02:00
Chayim Refael Friedman
933cce66d6
Merge pull request #20671 from ShoyuVanilla/explicit-preds-fix
fix: More precise clause filtering for `explicit_*_predicates_of`
2025-09-15 20:19:03 +00:00
Shoyu Vanilla
487cdbc07d fix: More precise clause filtering for explicit_*_predicates_of 2025-09-16 01:44:00 +09:00
Chayim Refael Friedman
4e286122d9 Port a bunch of stuff from rustc and fix a bunch of type mismatches/diagnostics
This started from porting coercion, but ended with porting much more.
2025-09-15 18:56:17 +03:00
Laurențiu Nicola
af5ca033fb
Merge pull request #20669 from ChayimFriedman2/testing-guide
internal: Add a testing guide
2025-09-15 08:01:02 +00:00
Chayim Refael Friedman
f6a7da8673 Add a testing guide 2025-09-15 10:48:26 +03:00
Chayim Refael Friedman
3c82a25860
Merge pull request #20667 from ChayimFriedman2/ns-cleanup2
internal: Add Regression Test For The One And The Only Issue #5514
2025-09-15 06:02:57 +00:00
Chayim Refael Friedman
f40e71c9de Add Regression Test For The One And The Only Issue #5514 2025-09-15 08:50:41 +03:00
Laurențiu Nicola
c88fb5036a
Merge pull request #20652 from ChayimFriedman2/cli-diags
internal: Improve `rust-analyzer diagnostics`
2025-09-15 05:42:46 +00:00
Shoyu Vanilla (Flint)
03e383098b
Merge pull request #20665 from ChayimFriedman2/error-notable
fix: Don't mark unknown type as implementing every notable trait
2025-09-15 05:39:17 +00:00
Chayim Refael Friedman
4515e789ed
Merge pull request #20666 from ChayimFriedman2/ns-cleanup1
minor: Add regression tests to some S-blocked-on-new-solver issues
2025-09-15 05:37:17 +00:00
Chayim Refael Friedman
91f32ed180 Add regression tests to some S-blocked-on-new-solver issues
That were fixed by the migration.
2025-09-15 08:25:17 +03:00
Chayim Refael Friedman
55b8d4e6ff Don't mark unknown type as implementing every notable trait
Because the new solver, will return "yes" for them (which is a good thing).
2025-09-15 07:57:19 +03:00
Chayim Refael Friedman
5025bfa146 Improve rust-analyzer diagnostics
In my experience the `processing <module>` messages make it harder to search for the actual diagnostics, so remove them and instead print the filename only if there is a diagnostic.

Also allow choosing the minimum severity.
2025-09-14 23:22:57 +03:00
Chayim Refael Friedman
d6d3c4b2ea
Merge pull request #20654 from ShoyuVanilla/predicates
fix: Infinite loop while elaborting predicates
2025-09-14 11:20:04 +00:00
Shoyu Vanilla
9f850ceb33 fix: Infinite loop while elaborting predicates 2025-09-14 20:08:40 +09:00
Shoyu Vanilla (Flint)
c2e1012fd8
Merge pull request #20635 from iorizu/fix-double-flycheck
fix: Don't trigger two flychecks when saving files that are part of targets
2025-09-14 09:11:30 +00:00
Laurențiu Nicola
c307fd8e33
Merge pull request #20657 from A4-Tacks/fix-before-else-incomplete-let
Fix extra semicolon before else in let-stmt
2025-09-13 13:49:45 +00:00
A4-Tacks
8a574ca862
Fix extra semicolon before else in let-stmt
Example
---
```rust
fn main() {
    let x = if true {
        ()
    } $0 else {};
}
```

**Before this PR**:

```rust
fn main() {
    let x = if true {
        ()
    } else if $1 {
        $0
    }; else {};
}
```

**After this PR**:

```rust
fn main() {
    let x = if true {
        ()
    } else if $1 {
        $0
    } else {};
}
```
2025-09-12 20:56:59 +08:00
Ifeanyi Orizu
68217c79b2 Minor refactoring 2025-09-11 10:38:34 -05:00
Shoyu Vanilla (Flint)
fa2f5f9efa
Merge pull request #20642 from ChayimFriedman2/wasm-safe
fix: Make `#[target_feature]` always safe on WASM
2025-09-11 05:09:26 +00:00
Laurențiu Nicola
7f38c057dc
Merge pull request #20653 from A4-Tacks/gen-function-empty-gen-param
Fix empty generic param list for generate_function
2025-09-11 05:08:00 +00:00
A4-Tacks
2d87bc3e6b
Fix empty generic param list for generate_function
Example
---
```rust
struct Foo<S>(S);
impl<S> Foo<S> {
    fn foo(&self) {
        self.bar()$0;
    }
}
```

**Before this PR**:

```rust
struct Foo<S>(S);
impl<S> Foo<S> {
    fn foo(&self) {
        self.bar();
    }

    fn bar<>(&self) ${0:-> _} {
        todo!()
    }
}
```

**After this PR**:

```rust
struct Foo<S>(S);
impl<S> Foo<S> {
    fn foo(&self) {
        self.bar();
    }

    fn bar(&self) ${0:-> _} {
        todo!()
    }
}
```
2025-09-11 10:23:02 +08:00
Shoyu Vanilla (Flint)
1800ec1931
Merge pull request #20649 from ChayimFriedman2/cast-unknown
fix: Always coerce in a cast, even when there are unknown types
2025-09-10 02:27:53 +00:00